-
Notifications
You must be signed in to change notification settings - Fork 47
chore: simplify rollup-boost
args
#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
I have to check first if there is any user using this feature. I like the pattern to ship the service with an easy UX to interact with the internal API endpoints but open to remove it if it is not widely used and the workflow to interact with those endpoints is more automatic than manual.
This one I would like to keep. I like having a single point of control to turn on the feature. It eliminates the risk of accidentally enabling the feature just by setting a configuration value. Also, there might be cases (local testing) in which you want to enable the feature and use the default values. |
Sounds good, I updated the PR to reintroduce this.
The main motivation for removing the debug commands was to eliminate the risk of configuring |
This PR cleans up the CLI args structure to improve ergonomics and remove redundant logic:
Commands
subcommand and debug commands. This command seems to be redundant since the debug API is already exposed over HTTP. This also created potential inconsistencies whereexecution_mode
could be set via CLI flags but then overridden separately via debug commands.--flashblocks
boolean flag. Instead, Flashblocks configuration is now optional viaOption<FlashblocksArgs>
. Flashblocks is enabled if any related--flashblocks-*
flags are specified.Args
toRollupBoostArgs
for clarity and consistency.