Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom renderer #241

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: Custom renderer #241

wants to merge 5 commits into from

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Feb 13, 2023

Resolves: #235

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Feb 13, 2023

E2E -

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 34445ad.

♻️ This comment has been updated with latest results.

topology/controllers.go Outdated Show resolved Hide resolved
topology/controllers.go Outdated Show resolved Hide resolved
topology/controllers.go Outdated Show resolved Hide resolved
"github.com/flanksource/incident-commander/db"
)

func QueryRenderComponents(ctx context.Context, systemTemplateID string) ([]api.Renderers, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshloop Should we keep this in db/topology.go as we keep all the database interactions in the db package

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed that was the convention I am supposed to follow. I took pkg/snapshot as a reference but looks like pkg/rules also does it.

topology/query.go Outdated Show resolved Hide resolved
topology/query.go Outdated Show resolved Hide resolved
topology/query.go Outdated Show resolved Hide resolved
@moshloop moshloop marked this pull request as draft September 12, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom renders per component / property type
4 participants