feat: add values.schema.json #220
Open
+1,101
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Jan 13, 2025
chart/values.schema.json
Outdated
| } | ||
| }, | ||
| "required": [ | ||
| "replicas", |
There was a problem hiding this comment.
Can we add required: false tags on these ?
There was a problem hiding this comment.
All the keys ? Should I just make required empty ?
But they will be based on our default values + user supplied ones, so these required settings would always be present
yashmehrotra
force-pushed
the
values-schema
branch
from
cb96d4c to
813c5e8
Compare
yashmehrotra
force-pushed
the
values-schema
branch
from
813c5e8 to
48ef52e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #142