fix: serialize test #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
commented
Nov 29, 2023
| "mode": "drwxr-xr-x", | ||
| "modified": testDateTime, | ||
| "modified": testDate, |
There was a problem hiding this comment.
@moshloop do we want this to be time.Time? I don't think any nested time.Time or time.Duration are preserved.
There was a problem hiding this comment.
They are preserved for cel here: https://github.com/flanksource/gomplate/blob/main/serialize.go#L34
There was a problem hiding this comment.
They aren't preserved for struct fields like in this test case.
https://github.com/flanksource/gomplate/pull/35/files#diff-9397650a743de05ce9f82381430e9f9abf49d001f199ef9bbe3a64d8b6f04f84R169-R184
adityathebe
force-pushed
the
fix/serialize-test
branch
from
0141359 to
3694961
Compare
adityathebe
force-pushed
the
fix/serialize-test
branch
from
329f9fe to
a533a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.