feat: add component name/type/parent/topologyid cache #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
comp-parent-cache
branch
from
a7a0049
to
79bfb68
Compare
yashmehrotra
commented
Feb 12, 2024
query/components_cache.go
Outdated
| @@ -24,25 +25,41 @@ const cacheJobBatchSize = 1000 | |||
| // <id> -> models.Component | |||
| var componentCache = cache.New[models.Component](gocache_store.NewGoCache(gocache.New(10*time.Minute, 10*time.Minute))) | |||
|
|
|||
| // <name/type/parentID/topologyID> -> models.Component | |||
| var componentNameTypeParentTopologyCache = cache.New[models.Component](gocache_store.NewGoCache(gocache.New(30*time.Minute, 30*time.Minute))) | |||
There was a problem hiding this comment.
@moshloop Is a 30 minute cache too long ? Or should I reduce it
yashmehrotra
commented
Feb 12, 2024
| func SyncComponentCache(ctx context.Context) error { | ||
| var next string | ||
| next := uuid.Nil.String() |
There was a problem hiding this comment.
Without this, the query was always failing with invalid input syntax for type uuid: ""
adityathebe
reviewed
Feb 12, 2024
adityathebe
reviewed
Feb 12, 2024
yashmehrotra
force-pushed
the
comp-parent-cache
branch
3 times, most recently
from
4f0fcec
to
87e4a33
Compare
yashmehrotra
force-pushed
the
comp-parent-cache
branch
from
87e4a33
to
b7f2433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.