Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: canary fixture updates #292

Merged
merged 4 commits into from
Oct 9, 2024
Merged

chore: canary fixture updates #292

merged 4 commits into from
Oct 9, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Oct 1, 2024

resolves: #289

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for flanksource-docs ready!

Name Link
🔨 Latest commit 0885fea
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-docs/deploys/670660112a79080008692a1a
😎 Deploy Preview https://deploy-preview-292--flanksource-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for canarychecker canceled.

Name Link
🔨 Latest commit 0885fea
🔍 Latest deploy log https://app.netlify.com/sites/canarychecker/deploys/67066011a362ff0008503dec

Copy link

gitguardian bot commented Oct 1, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13982848 Triggered Basic Auth String fb64d8b canary-checker/docs/reference/1-http.mdx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@adityathebe adityathebe marked this pull request as ready for review October 1, 2024 17:20
@moshloop
Copy link
Member

moshloop commented Oct 2, 2024

@adityathebe - I think the canary-cgecker module might need updating - also check the lint errors

@adityathebe adityathebe force-pushed the feat/canary-fixture-updates branch 2 times, most recently from c0c43eb to 5429bda Compare October 2, 2024 10:11
@adityathebe
Copy link
Member Author

@adityathebe - I think the canary-cgecker module might need updating - also check the lint errors

@moshloop it was due to the fixture imports on secret-management doc.

That same file is on two different depths inside mission-control doc and the import path fails on one but is valid on another.

Left that file unchanged for now.

@adityathebe adityathebe force-pushed the feat/canary-fixture-updates branch 4 times, most recently from 1d6e606 to 6c796b9 Compare October 9, 2024 10:47
@moshloop moshloop merged commit 877db8e into main Oct 9, 2024
8 of 9 checks passed
@moshloop moshloop deleted the feat/canary-fixture-updates branch October 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all endpoints/interval with url and schedule
2 participants