-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: canary fixture updates #292
Conversation
✅ Deploy Preview for flanksource-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for canarychecker canceled.
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
13982848 | Triggered | Basic Auth String | fb64d8b | canary-checker/docs/reference/1-http.mdx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
3605a8a
to
f607f3a
Compare
f607f3a
to
0777c64
Compare
@adityathebe - I think the canary-cgecker module might need updating - also check the lint errors |
c0c43eb
to
5429bda
Compare
@moshloop it was due to the fixture imports on secret-management doc. That same file is on two different depths inside mission-control doc and the import path fails on one but is valid on another. Left that file unchanged for now. |
5429bda
to
fae451a
Compare
fae451a
to
5429bda
Compare
1d6e606
to
6c796b9
Compare
6c796b9
to
0885fea
Compare
resolves: #289