fix: panic err in counter metric creation #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
fix-gauge-metric
branch
2 times, most recently
from
1cc7668 to
a87ae34
Compare
moshloop
reviewed
Oct 5, 2023
checks/metrics.go
Outdated
| func getWithEnvironment(ctx *context.Context, r *pkg.CheckResult) (*context.Context, error) { | ||
| // Convert result Data into JSON for templating | ||
| // as gomplate does not render child map data correctly | ||
| var rData map[string]any |
There was a problem hiding this comment.
Fixing this issue in #1288
I want to try and avoid unnecessary marshalling - if it needs to happen should be in gomplate.
moshloop
reviewed
Oct 5, 2023
| } | ||
|
|
||
| case HistogramType: | ||
| if err := getOrCreateHistogram(m); err != nil { | ||
| result.ErrorMessage(fmt.Errorf("cannot create histogram %s with labels %v", m.Name, m.Labels)) | ||
| logger.Errorf("cannot create histogram %s with labels %v: %w", m.Name, m.Labels, err) |
There was a problem hiding this comment.
Why would failing to create a metric, not fail the check ?
There was a problem hiding this comment.
If the check passes but if there is an instrumentation error from our side, the check in itself still passes right ?
It might create false positives this way
yashmehrotra
force-pushed
the
fix-gauge-metric
branch
from
a87ae34 to
5e7b9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1289