fix: deletion logic for transformed checks #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
fix-deletion-logic-for-transformed-checks
branch
2 times, most recently
from
8183a8f
to
ca2ba2b
Compare
yashmehrotra
commented
Jul 13, 2023
yashmehrotra
force-pushed
the
fix-deletion-logic-for-transformed-checks
branch
2 times, most recently
from
cb25ffc
to
f3d067e
Compare
moshloop
reviewed
Jul 17, 2023
pkg/db/canary.go
Outdated
| if !utils.Contains(models.CheckHealthStatuses, status) { | ||
| return fmt.Errorf("invalid check health status: %s", status) | ||
| } | ||
| updates["status"] = status | ||
| } | ||
| return Gorm.Table("checks"). |
There was a problem hiding this comment.
I think we want to insert a new check rather than update the old checks
There was a problem hiding this comment.
Do you mean check_status ?
Ie. Insert new check status and mark the existing check as deleted ?
moshloop
reviewed
Jul 17, 2023
pkg/jobs/canary/canary_jobs.go
Outdated
| for _, checkID := range checksToRemove { | ||
| strategy := checkIDDeleteStrategyMap[checkID] | ||
| var status string | ||
| if strategy == "MarkHealthy" { |
There was a problem hiding this comment.
Can we use Constants ?
I think ignore should be the default strategy - i.e. do not insert or update anything, just mark as deleted.
yashmehrotra
force-pushed
the
fix-deletion-logic-for-transformed-checks
branch
from
85d3161
to
e46566c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://mission-control.azure.lab.flanksource.com/incidents/0188ba77-539b-f928-9abe-75b84caf97dc and https://mission-control.azure.lab.flanksource.com/incidents/018929f8-be24-2368-7983-a4e47955d5b5