fix: cron flow for canaries #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Jun 29, 2023
pkg/jobs/canary/canary_jobs.go
Outdated
| entry = findCronEntry(canary) | ||
| if entry != nil && time.Until(entry.Next) < 1*time.Hour { | ||
| // run all regular canaries on startup | ||
| // Run canary on startup |
There was a problem hiding this comment.
Run all regularly scheduled canaries on startup (<1h) and not daily/weekly schedules
yashmehrotra
force-pushed
the
fix-canary-cron
branch
from
675fb21
to
590de90
Compare
adityathebe
reviewed
Jun 30, 2023
| if entry != nil && time.Until(entry.Next) < 1*time.Hour { | ||
| // run all regular canaries on startup | ||
| //Run all regularly scheduled canaries on startup (<1h) and not daily/weekly schedules | ||
| if entry != nil && time.Until(entry.Next) < 1*time.Hour && !exists { |
There was a problem hiding this comment.
Is this condition ever satisfied? If the cron entry is not nil, then the update time will also exist.
There was a problem hiding this comment.
have updated the code to modify entry
adityathebe
reviewed
Jun 30, 2023
pkg/jobs/canary/canary_jobs.go
Outdated
| if entry != nil && time.Until(entry.Next) < 1*time.Hour { | ||
| // run all regular canaries on startup | ||
| //Run all regularly scheduled canaries on startup (<1h) and not daily/weekly schedules | ||
| if entry != nil && time.Until(entry.Next) < 1*time.Hour && !exists { | ||
| job = entry.Job.(CanaryJob) |
There was a problem hiding this comment.
Yes, from a ux perspective if I add a check that runs every 15 minutes I don't want to wait for 15m to see if it worked
There was a problem hiding this comment.
@moshloop I meant just this one line
job = entry.Job.(CanaryJob)
adityathebe
reviewed
Jun 30, 2023
pkg/jobs/canary/canary_jobs.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("failed to schedule canary %s/%s: %v", canary.Namespace, canary.Name, err) | ||
| } | ||
| *entry = CanaryScheduler.Entry(entryID) |
There was a problem hiding this comment.
This panics in the first run when the entry var is nil.
yashmehrotra
force-pushed
the
fix-canary-cron
branch
from
a23a001
to
ee1410e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1105