chore: use total runs intead of uptime.Total()

pkg/api.go

@@ -91,10 +91,6 @@ type Uptime struct {
 	LastFail *time.Time `json:"last_fail,omitempty"`
 }
 
-func (u Uptime) Total() int {
-	return u.Passed + u.Failed
-}
-
 func (u Uptime) String() string {
 	if u.Passed == 0 && u.Failed == 0 {
 		return ""

pkg/api/api.go

@@ -74,7 +74,7 @@ func CheckDetails(c echo.Context) error {
 	}
 
 	checkSummary := *summary[0]
-	totalChecks := checkSummary.Uptime.Total()
+	totalChecks := checkSummary.TotalRuns
 	if totalChecks <= desiredNumOfCheckStatuses {
 		q.WindowDuration = 0 // No need to perform window aggregation
 	} else {

pkg/api/utils.go

@@ -9,12 +9,13 @@ func errorResonse(c echo.Context, err error, code int) error {
 	return c.JSON(code, e)
 }
 
-// returns the absolute value of i.
-// math.Abs only supports float64 and this avoid hairy type conversions.
-func abs(i int) int {
-	if i > 0 {
-		return i
+// abs returns the absolute value of i.
+// math.Abs only supports float64 and this avoids the needless type conversions
+// and ugly expression.
+func abs(n int) int {
+	if n > 0 {
+		return n
 	}
 
-	return -i
+	return -n
 }