Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use CodeMirror for displaying raw result #1337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jan 28, 2025

No description provided.

@jstucke jstucke self-assigned this Jan 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (fd305a1) to head (decf3ee).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
- Coverage   92.55%   91.68%   -0.88%     
==========================================
  Files         383      376       -7     
  Lines       24466    21047    -3419     
==========================================
- Hits        22645    19297    -3348     
+ Misses       1821     1750      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorpvom
Copy link
Member

dorpvom commented Feb 14, 2025

I was curious what PR #1337 would be out of principal.. Now. I don't get it. What does this do @jstucke?

@jstucke
Copy link
Collaborator Author

jstucke commented Feb 14, 2025

I was curious what PR #1337 would be out of principal.. Now. I don't get it. What does this do @jstucke?

Seems I forgot to include a description, sorry. The raw JSON result preview currently works with syntax highlighting (the same as the file preview). That isn't bad, but large results can get kinda unwieldy fast and it would be nice if it was possible to fold in some parts of it. This isn't really possible with simple highlighted code. But there is an alternative: on the GraphQL Search page we use CodeMirror to display code. CodeMirror does have an option to enable folding in parts of the code. Thus, I simply replaced the raw result element with CodeMirror.

@jstucke jstucke force-pushed the raw-result-codemirror branch from eb08674 to decf3ee Compare February 14, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants