chore: updated pip dependencies #1335
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
==========================================
- Coverage 92.53% 91.80% -0.73%
==========================================
Files 381 376 -5
Lines 24245 21040 -3205
==========================================
- Hits 22435 19316 -3119
+ Misses 1810 1724 -86 ☔ View full report in Codecov by Sentry. |
jstucke
force-pushed
the
update-pip-deps
branch
from
7f75186 to
62107aa
Compare
There was a problem hiding this comment.
Iirc the versions were pinned using == intentionally to have a reproducible environment for the CI. On the other hand using ~= should work as well.
I personally use poetry to define my dependencies using compatibility specifiers in pyproject.toml and lock the dependencies using hashes in a poetry.lock lockfile.
I'd suggest to replace our various requirements.txt with several poetry groups.
What do you think?
| @@ -2,34 +2,26 @@ | |||
| testresources==2.0.1 | |||
|
|
|||
| # General python dependencies | |||
| appdirs==1.4.4 | |||
There was a problem hiding this comment.
There is a corresponding mock in docsrc/conf.py that needs to be removed.
Same for flaky. I'm not sure if there are others since it is hard to see which dependencies were removed.
Interesting idea. A bit out of scope for this PR but we should definitely discuss this further. This could also fix the problems that come from a missing venv. |
* replaced flaky with pytest-rerunfailures (flaky does not work with newer versions of pytest) * removed unused dependency appdirs * removed redundant dependencies (defined in frontend/backend but also in pre_install)
jstucke
force-pushed
the
update-pip-deps
branch
from
62107aa to
1d3fc37
Compare
I opened #1343 to track this |
replaced flaky with pytest-rerunfailures (flaky does not work with newer versions of pytest)
removed redundant dependencies