Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve open view with animation and fix web view size in the first appear #124

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Improve open view with animation and fix web view size in the first appear #124

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
78248f1
Improve animation and view frame
MaatheusGois Jan 6, 2023
bbc9561
Improve open webview with animation option
MaatheusGois Jan 6, 2023
37d40e9
feat(Feature/Style-And-Destroy): Swift Format And Add Option To Remov…
math-gois Jan 6, 2023
916d828
Merge pull request #1 from MaatheusGois/feature/style-and-destroy
MaatheusGois Jan 6, 2023
14fda83
Update ReCaptchaWebViewManager.swift
MaatheusGois Jan 9, 2023
01231f5
[TODO] Back code
MaatheusGois Jan 9, 2023
2b434cb
feat(Master): Enable Flags ⚗️
math-gois Jan 9, 2023
8211722
feat(Master): Fix Errors In Loader ✏️
math-gois Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ReCaptcha/Classes/ReCaptcha.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ public class ReCaptcha {

Starts the challenge validation
*/
public func validate(on view: UIView, resetOnError: Bool = true, completion: @escaping (ReCaptchaResult) -> Void) {
public func validate(on view: UIView, animated: Bool = false, resetOnError: Bool = true, completion: @escaping (ReCaptchaResult) -> Void) {
manager.shouldResetOnError = resetOnError
manager.completion = completion

manager.validate(on: view)
manager.validate(on: view, animated: animated)
}


Expand Down
11 changes: 10 additions & 1 deletion ReCaptcha/Classes/ReCaptchaWebViewManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,23 @@ internal class ReCaptchaWebViewManager {

Starts the challenge validation
*/
func validate(on view: UIView) {
func validate(on view: UIView, animated: Bool = false) {
#if DEBUG
guard !shouldSkipForTests else {
completion?(.token(""))
return
}
#endif
if animated {
webView.alpha = 0

UIView.animate(withDuration: 0.2, delay: .zero, options: [.transitionCrossDissolve]) {
self.webView.alpha = 1
}
}
webView.isHidden = false
webView.frame = view.frame

view.addSubview(webView)

executeJS(command: .execute)
Expand Down