Update/u3v refactor #254
Merged
Update/u3v refactor #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xinyuli1204
commented
Mar 4, 2024
•
xinyuli1204
commented
- Polymorphic U3V class implementation
- Following consistent naming convention (snake case) ( sync_frame_count, set_realtime, set_gain ....)
- fix u3vGendc on main branch
- Return -1 for devices has no frame count #253 integrate design for frame count in this issue
…-kit into Update/u3v-refactor
| @@ -312,6 +286,10 @@ class U3V { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| virtual void get(std::vector<Halide::Buffer<>>& outs){}; | |||
There was a problem hiding this comment.
It's better to be pure virtual function (virtual void get(...) = 0) to avoid mistake on overriding in the derived.
src/bb/image-io/rt_u3v.h
Outdated
| } | ||
|
|
||
|
|
||
| void set_realtime(std::vector<ArvBuffer *> &bufs, int timeout_us = 3 * 1000 * 1000){ |
There was a problem hiding this comment.
This method doesn't look like "setting realtime". Maybe consume_old_buffer or ensure_newest_buffer or something else similar is better?
| } | ||
| void get(std::vector<Halide::Buffer<>>& outs) override{ | ||
| auto timeout_us = 30 * 1000 * 1000; | ||
| if (sim_mode_){ |
There was a problem hiding this comment.
Is sim_mode in U3VRealCam required? It looks force_sim_mode leads to use U3VFakeCam class, not sim_mode in U3vRealCam.
There was a problem hiding this comment.
@Fixstars-iizuka if u3vRealCam doesn't detect any device it will fall back to sim_mode
for example:
Node n = b.add("image_io_u3v_cameraN_u8x2")().set_param(
Param("num_devices", num_device),
Param("pixel_format", "Mono8")
);
the force_sim_mode is false, but since there is no device detected it fallback to sim_mode
Fixstars-iizuka
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.