Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/builder dispose hook #175

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Feature/builder dispose hook #175

merged 5 commits into from
Dec 21, 2023

Conversation

iitaku
Copy link
Collaborator

@iitaku iitaku commented Dec 12, 2023

  • Introduced BuildingBlock::register_disposer
  • register_disposer takes the symbol name for the dispose function which is defined in rt.h
  • The dispose function will take one argument (const char *id) which is tied with the building block instance. id value is always identical with ion::Node::id().

@iitaku iitaku changed the base branch from master to feature/halide-16 December 12, 2023 20:39
@iitaku iitaku changed the base branch from feature/halide-16 to master December 12, 2023 21:19
@Fixstars-momoko
Copy link
Contributor

@iitaku Which c++ version supposed to be used?

The current CMakeLists.txt

#
# CMake common settings
#
set(CMAKE_C_STANDARD 11)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) # This is required to export symbols on windows platform
set(CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake" ${CMAKE_MODULE_PATH})

Tried to build on Windows 10:

C:\Users\momoko\cambria\Sensing-Dev\ion-kit\test\c_api.cc(11,25): error C7555: 指定された初期化子を使用するには少なくとも '/std:c++20' が必要です [C:\Users\momoko\cambria\Sens
ing-Dev\ion-kit\build\test\c_api.vcxproj]
C:\Users\momoko\cambria\Sensing-Dev\ion-kit\test\c_api.cc(26,25): error C7555: 指定された初期化子を使用するには少なくとも '/std:c++20' が必要です [C:\Users\momoko\cambria\Sens
ing-Dev\ion-kit\build\test\c_api.vcxproj]
C:\Users\momoko\cambria\Sensing-Dev\ion-kit\test\c_api.cc(167,25): error C7555: 指定された初期化子を使用するには少なくとも '/std:c++20' が必要です [C:\Users\momoko\cambria\Sen
sing-Dev\ion-kit\build\test\c_api.vcxproj]
C:\Users\momoko\cambria\Sensing-Dev\ion-kit\test\c_api.cc(206,25): error C7555: 指定された初期化子を使用するには少なくとも '/std:c++20' が必要です [C:\Users\momoko\cambria\Sen
sing-Dev\ion-kit\build\test\c_api.vcxproj]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iitaku Windows (non-UNIX) does not have m.lib and stdc+.lib

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@iitaku iitaku merged commit a56445a into master Dec 21, 2023
1 check passed
@iitaku iitaku deleted the feature/builder-dispose-hook branch January 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants