Merge pull request #330 from fixstars/fix/ion-contrib-python-windows

Fix/ion-contrib-python on windows
fixstars · Oct 1, 2024 · 8a42b0d · 8a42b0d
2 parents 767b6ad + e0fdc1a
commit 8a42b0d
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/python/ionpy/native.py b/python/ionpy/native.py
@@ -7,16 +7,14 @@
 if platform.system() == 'Windows':
     ion_core_module = os.path.join(pre_built_path, 'windows/ion-core.dll')
     ion_bb_module = os.path.join(pre_built_path, 'windows/ion-bb.dll')
+    os.add_dll_directory(os.path.join(pre_built_path, 'windows'))
 elif platform.system() == 'Darwin':
     ion_core_module = os.path.join(pre_built_path, 'macos/libion-core.dylib')
     ion_bb_module = os.path.join(pre_built_path, 'macos/libion-bb.dylib')
 elif platform.system() == 'Linux':
     ion_core_module = os.path.join(pre_built_path, 'linux/libion-core.so')
     ion_bb_module = os.path.join(pre_built_path, 'linux/libion-bb.so')
 
-# libion-core.so must be in a directory listed in $LD_LIBRARY_PATH.
-# ion-core.dll must be in a directory listed in %PATH%.
-# libion-core.dylib must be in a directory listed in $DYLD_LIBRARY_PATH.
 ion_core = ctypes.cdll.LoadLibrary(ion_core_module)
 ion_bb = ctypes.cdll.LoadLibrary(ion_bb_module)