Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to dpy2 #230

Merged
merged 14 commits into from
Dec 31, 2023
Merged

Add support to dpy2 #230

merged 14 commits into from
Dec 31, 2023

Conversation

ltzmax
Copy link

@ltzmax ltzmax commented Oct 23, 2023 •
edited
Loading

This is a drafted pr where i'll add support for some expect those 2 prs thats already open to add support for it.

pre-commit-ci bot and others added 7 commits July 12, 2023 20:00
@pre-commit-ci
[meta] update pre-commit (fixator10#224)
07d1a8b 
updates:
- [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@dependabot
[meta]: Bump crowdin/github-action from 1.8.1 to 1.11.0 (fixator10#222)
c2f482b 
Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 1.8.1 to 1.11.0.
- [Release notes](https://github.com/crowdin/github-action/releases)
- [Commits](crowdin/github-action@v1.8.1...v1.11.0)

---
updated-dependencies:
- dependency-name: crowdin/github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
[meta]: Bump crowdin/github-action from 1.11.0 to 1.12.0 (fixator10#226)
c977b1d 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
[meta]: Bump actions/checkout from 3 to 4 (fixator10#227)
3bb3aca 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pre-commit-ci
[meta] update pre-commit (fixator10#228)
98ab3ac 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@dependabot
[meta]: Bump crowdin/github-action from 1.12.0 to 1.13.1 (fixator10#229)
0affbbc 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ltzmax
Port some cogs to dpy2
24ac03d
@ltzmax ltzmax marked this pull request as draft October 23, 2023 15:34
@ltzmax ltzmax marked this pull request as ready for review October 23, 2023 15:56
@ltzmax
Copy link
Author

ltzmax commented Oct 23, 2023

Alright, should be ready now.
The only i didnt do: steamcommunity, reverseimagesearch and captcha

  • Steamcommunity require to support current lib version which it doesn't, either lock to a version where it works or add support for current.
  • reverseimagesearch couldnt get api to test it.
  • captcha require some work.

@fixator10 fixator10 self-assigned this Oct 24, 2023
fixator10
fixator10 requested changes Oct 24, 2023
View reviewed changes
datautils/__init__.py Outdated Show resolved Hide resolved
generalchannel/__init__.py Outdated Show resolved Hide resolved
godvilledata/__init__.py Outdated Show resolved Hide resolved
massthings/__init__.py Outdated Show resolved Hide resolved
moreutils/__init__.py Outdated Show resolved Hide resolved
ltzmax and others added 5 commits October 24, 2023 12:17
@ltzmax @fixator10
Update datautils/__init__.py
4f4d088 
Co-authored-by: Fixator10 <[email protected]>
Signed-off-by: MAX <[email protected]>
@ltzmax @fixator10
Update generalchannel/__init__.py
d1adce6 
Co-authored-by: Fixator10 <[email protected]>
Signed-off-by: MAX <[email protected]>
@ltzmax @fixator10
Update massthings/__init__.py
b40b534 
Co-authored-by: Fixator10 <[email protected]>
Signed-off-by: MAX <[email protected]>
@ltzmax @fixator10
Update moreutils/__init__.py
e18f03d 
Co-authored-by: Fixator10 <[email protected]>
Signed-off-by: MAX <[email protected]>
@ltzmax @fixator10
Update godvilledata/__init__.py
bc2b240 
Co-authored-by: Fixator10 <[email protected]>
Signed-off-by: MAX <[email protected]>
@ltzmax
Copy link
Author

ltzmax commented Oct 24, 2023

also note for weather, the api is apple's now and will no longer allow you to make api + the current api you have seems to be deleted by apple so i was not able to test the cog properly.

@fixator10
Copy link
Owner

Ye, thats known, i most likely will need to rewrite it entirely

@fixator10 fixator10 self-requested a review October 24, 2023 10:53
fixator10
fixator10 approved these changes Dec 31, 2023
View reviewed changes
Copy link
Owner

@fixator10 fixator10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datautils failing, but its not init issue, taking it from here

@fixator10 fixator10 merged commit 63ad9cf into fixator10:V3_dpy2 Dec 31, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixator10 fixator10 fixator10 approved these changes

Assignees

@fixator10 fixator10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltzmax @fixator10