Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ruby version in generated app #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove Ruby version in generated app #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffb63ee
Delete .ruby-version file
murugan-r Jul 16, 2018
b5911d9
Remove ruby version in Gemfile
murugan-r Jul 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,11 @@ def render_file(filename)
# Set up dotenv
file ".env.development", render_file(".env.development")

create_file ".gitignore" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this change? Does it relate to the ruby version?

Copy link
Contributor Author

@murugan-r murugan-r Aug 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raghubetina
Yes. Since in latest rails .gitignore is not included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? I still get one:

testgitignore HEAD % ls -a
.             .gitignore    Gemfile.lock  app           config.ru     log           storage       vendor
..            .ruby-version README.md     bin           db            package.json  test
.git          Gemfile       Rakefile      config        lib           public        tmp
testgitignore HEAD % rails -v
Rails 5.2.0

"/tmp/*
/log/*"
end unless File.exist?(".gitignore")

append_file ".gitignore" do
<<-EOF.gsub(/^ /, "")

Expand Down Expand Up @@ -292,6 +297,9 @@ def render_file(filename)

generate "rspec:install"

remove_file ".ruby-version"
gsub_file "Gemfile", /^ruby .*/, ""

remove_file ".rspec"
file ".rspec", render_file(".rspec")

Expand Down