Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct typo for Contributors accounts link Update Contributors.md #89258

Closed
wants to merge 1 commit into from

Conversation

shebll
Copy link

@shebll shebll commented Oct 1, 2024

Replace All
'] (https://github.com'
with a space that breaks the text link
to
'](https://github.com'
to fix the text link

Replace All '] (https://github.com' with a space that breaks the text link
to '](https://github.com' to fix the text link
@shebll
Copy link
Author

shebll commented Oct 1, 2024

before edit on the main branch

Screenshot from 2024-10-01 14-02-58

after make in patch-1 branch

Screenshot from 2024-10-01 14-03-33

Copy link
Member

@Roshanjossey Roshanjossey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! You've successfully submitted a pull request. 🎉 🥳 🎊
Unfortunately, we can't merge and have to close this pull request because of merge conflicts.
If you really wanted to make these changes, please read design decisions

If you didn't make changes to other lines deliberately, it's possible that your IDE made the changes with a utility like prettier. Next time, make sure that you only add your changes by using 'git add -p' and rather than 'git add Contributors.md'

Feel free to ask me any questions if you need further clarifications :)

Cheers

If you're interested in trying this again 🚀, please try adding your entry somewhere in the middle of Contributors.md.
Also, please don't change other lines as it could cause merge conflicts. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants