Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDS Build: set clean-fds to true for clean-hypre and clean-sundials #13690

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

cxp484
Copy link
Collaborator

@cxp484 cxp484 commented Nov 4, 2024

@gforney, I wanted to mean that we should clean fds obj and mod files if --clean-hypre and --clean-sundials are specified. I did it for the linux part. Could you please do it for the Windows one.

@rmcdermo rmcdermo merged commit 978624e into firemodels:master Nov 4, 2024
5 checks passed
@gforney
Copy link
Contributor

gforney commented Nov 4, 2024 via email

@gforney
Copy link
Contributor

gforney commented Nov 4, 2024

let me know if you see something different

@cxp484
Copy link
Collaborator Author

cxp484 commented Nov 4, 2024

@gforney Great, I just tested the Windows version, and it's working as you described. I see that you're removing FDS files within both build_hypre.bat and build_sundials.bat, so the Windows version looks good. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants