Merge pull request #13124 from mcgratta/hrrpul

FDS Source: Remove HRRPUL and RHRRPUL
firemodels · Jul 5, 2024 · 8db588a · 8db588a
2 parents ae64265 + 790bda3
commit 8db588a
Show file tree

Hide file tree

Showing 112 changed files with 516 additions and 444 deletions.
diff --git a/Manuals/FDS_User_Guide/FDS_User_Guide.tex b/Manuals/FDS_User_Guide/FDS_User_Guide.tex
@@ -8324,11 +8324,12 @@ \subsection{Control Function: \texorpdfstring{{\tt PERCENTILE}}{PERCENTILE} }
 
 The {\ct PERCENTILE} function is useful for computing flame heights. Consider the following input lines:
 \begin{lstlisting}
-&DEVC XB=0,0,0,0,0.05,4.95, QUANTITY='HRRPUL', POINTS=50, Z_ID='z', ID='qdot' /
+&DEVC XB=0,0,0,0,0.05,4.95, QUANTITY='HRRPUV', SPATIAL_STATISTIC='VOLUME INTEGRAL'
+      DX=1., DY=1., DZ=0.05, POINTS=50, Z_ID='z', ID='qdot' /
 &CTRL ID='pct', FUNCTION_TYPE='PERCENTILE', INPUT_ID='qdot', PERCENTILE=0.95 /
 &DEVC ID='L_F', XYZ=0,0,0, QUANTITY='CONTROL VALUE', CTRL_ID='pct', UNITS='m' /
 \end{lstlisting}
-The first {\ct DEVC} line represents a vertical profile of {\ct 'HRRPUL'} or Heat Release Rate Per Unit Length (kW/m). These 50 values result from integrating the heat release rate per unit volume over the two horizontal directions. The {\ct CTRL} function takes these 50 values at 50 uniformly spaced heights between 0.05~m and 4.95~m and calculates the height at which 95~\% of the fire's energy has been released. Note that for a 10~cm grid, the vertical array of points are located at cell centers, which is why the discretized integration is done the way it is described above. The second {\ct DEVC} line simply takes the value calculated by the control function and prints it out in the file of time histories, {\ct CHID\_devc.csv}. The 50 values of {\ct 'HRRPUL'} are time-averaged and written to the file, {\ct CHID\_line.csv}. Note that the flame heights written to {\ct CHID\_devc.csv} are time-averaged over the time interval between printouts. If you set {\ct DT\_DEVC} to a very small value (i.e. less than the time step), you will obtain a time-history of instantaneous flame heights.
+The first {\ct DEVC} line represents a vertical profile of the heat release rate per unit volume integrated over horizontal slices of dimension {\ct 2*DX}, {\ct 2*DY}, and {\ct 2*DZ}. The {\ct CTRL} function takes these 50 values at 50 uniformly spaced heights between 0.05~m and 4.95~m and calculates the height at which 95~\% of the fire's energy has been released. Note that for a 10~cm grid, the vertical array of points are located at cell centers, which is why the discretized integration is done the way it is described above. The second {\ct DEVC} line simply takes the value calculated by the control function and prints it out in the file of time histories, {\ct CHID\_devc.csv}. The 50 integrals of {\ct 'HRRPUV'} are time-averaged and written to the file, {\ct CHID\_line.csv}. Note that the flame heights written to {\ct CHID\_devc.csv} are time-averaged over the time interval between printouts. If you set {\ct DT\_DEVC} to a very small value (i.e. less than the time step), you will obtain a time-history of instantaneous flame heights.
 
 
 
@@ -11081,7 +11082,6 @@ \section{Gas Phase Output Quantities}
 {\ct EXTINCTION COEFFICIENT}                    & Section~\ref{info:visibility}                     & 1/m               & D,I,P,S      \\ \hline
 {\ct F\_X, F\_Y, F\_Z}                          & Momentum terms, $F_x$, $F_y$, $F_z$               & m/s$^2$           & D,I,P,S      \\ \hline
 {\ct H}                                         & $\cH=|\bu|^2/2 + \tp/\rho    $                    & (m/s)$^2$         & D,I,P,S      \\ \hline
-{\ct HRRPUL}                                    & $\int \dq''' \, \d x \, \d y$                     & kW/m              & D            \\ \hline
 {\ct HRRPUV}                                    & $\dq'''$                                          & kW/m$^3$          & D,I,P,S      \\ \hline
 {\ct HRRPUV REAC}$^6$                           & $\dq'''$ for {\ct REAC\_ID}                       & kW/m$^3$          & D,S          \\ \hline
 {\ct IDEAL GAS PRESSURE}                        & $\bar{p}=\rho R T / \overline{W}$                 & Pa                & D,I,P,S      \\ \hline

diff --git a/Source/data.f90 b/Source/data.f90
@@ -598,18 +598,6 @@ SUBROUTINE DEFINE_OUTPUT_QUANTITIES
 OUTPUT_QUANTITY(113)%UNITS = 'kW/m2'
 OUTPUT_QUANTITY(113)%SHORT_NAME  = 'hflux'
 
-! Special integration of HRRPUV
-
-OUTPUT_QUANTITY(120)%NAME  = 'HRRPUL'
-OUTPUT_QUANTITY(120)%UNITS  = 'kW/m'
-OUTPUT_QUANTITY(120)%SHORT_NAME  = 'hrrpul'
-
-OUTPUT_QUANTITY(121)%NAME  = 'RHRRPUL'
-OUTPUT_QUANTITY(121)%UNITS  = 'kW/m'
-OUTPUT_QUANTITY(121)%SHORT_NAME  = 'rhrrpul'
-
-OUTPUT_QUANTITY(120:121)%SLCF_APPROPRIATE = .FALSE.
-
 ! Special Outputs for Partially Stirred Batch Reactor Model
 
 OUTPUT_QUANTITY(130)%NAME  = 'EXTINCTION'

diff --git a/Source/dump.f90 b/Source/dump.f90
@@ -7566,21 +7566,6 @@ REAL(EB) RECURSIVE FUNCTION GAS_PHASE_OUTPUT(T,DT,NM,II,JJ,KK,IND,IND2,Y_INDEX,Z
       ENDIF
       GAS_PHASE_OUTPUT_RES = (GAS_PHASE_OUTPUT_RES - K_G*(TMP(IP,JP,KP)-TMP(II,JJ,KK))*R_DN)*0.001
 
-   CASE(120) ! HRRPUL
-      GAS_PHASE_OUTPUT_RES = 0._EB
-      DO J=1,JBAR
-         DO I=1,IBAR
-            GAS_PHASE_OUTPUT_RES = GAS_PHASE_OUTPUT_RES + Q(I,J,KK)*DX(I)*RC(I)*DY(J)*0.001
-         ENDDO
-      ENDDO
-   CASE(121) ! RHRRPUL
-      GAS_PHASE_OUTPUT_RES = 0._EB
-      DO J=1,JBAR
-         DO I=1,IBAR
-            GAS_PHASE_OUTPUT_RES = GAS_PHASE_OUTPUT_RES - QR(I,J,KK)*DX(I)*RC(I)*DY(J)*0.001
-         ENDDO
-      ENDDO
-
    CASE(130) ! EXTINCTION
       ZZ_GET(1:N_TRACKED_SPECIES) = ZZ(II,JJ,KK,1:N_TRACKED_SPECIES)
       ZZ_FUEL = 0._EB