Add links to further profiler resources and forums #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canova
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Rendered version looks pretty good to me! Thanks for spending time on it!
@julienw adding you to the loop as well. It's an r+ for me but wanted you to see the PR too. Feel free to stamp it.
| - 🔎 Interested in learning how the profiler frontend works? Take a look at our [developer docs!](https://github.com/firefox-devtools/profiler/tree/main/docs-developer) | ||
| - ⚙️ Want to understand the C++ Gecko Profiler backend? Check out the [Firefox source docs](https://firefox-source-docs.mozilla.org/tools/profiler/index.html) or the [source itself!](https://searchfox.org/mozilla-central/source/tools/profiler) | ||
| - 💬 Feedback or ideas? Let us know in our [Github discussions!](https://github.com/firefox-devtools/profiler/discussions) | ||
| - 👋 Can't find what you need? Got a complicated question or profile? Come and chat to us in the [*Firefox Profiler* room on Matrix.](https://chat.mozilla.org/#/room/#profiler:mozilla.org) |
There was a problem hiding this comment.
Oh, I don't remember seeing "chat to us" phrase that much before. I usually see "chat with us". Is this more British English?
There was a problem hiding this comment.
Ah, good point! I think "chat with us" would probably be better.
|
This looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in today's meeting, here's my idea of how we could link in further resources from the documentation main page. Something similar could also be added to the main profiler page, if we wanted.
┆Issue is synchronized with this Jira Task