Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel netcdf #596

Merged
merged 17 commits into from
Feb 10, 2025
Merged

Parallel netcdf #596

merged 17 commits into from
Feb 10, 2025

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Dec 17, 2024

Fixes #556 and #378

TODOs

  • Check that plotting still works (compare to existing examples)
  • CI passing
  • Cleanup
  • Add info to install parallel version to docs
  • Remove tweaks to build system
  • Final check
  • Does the website build?

@tommbendall tommbendall added parallel Relates to parallel capability optimisation Involves optimising performance of code labels Dec 17, 2024
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! This is a real neatening up and is really going to help with outputting in parallel -- I don't think I'd have been able to do this, so we've been really lucky to have you solve this.

I've followed the install instructions on my local machine, ran a test in parallel and made a plot (with the tomplot change) and all worked. I'd be happy to merge this once we resolve the testing

tommbendall
tommbendall previously approved these changes Dec 18, 2024
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @connorjward, I'll approve this subject to passing tests

@tommbendall tommbendall added the admin Involves admin of the repository or associated website label Dec 19, 2024
@connorjward connorjward marked this pull request as ready for review January 10, 2025 11:27
@JHopeCollins JHopeCollins dismissed their stale review February 10, 2025 11:29

Changes made

@tommbendall tommbendall merged commit eb81c4b into main Feb 10, 2025
4 checks passed
@tommbendall tommbendall deleted the connorjward/parallel-netcdf branch February 10, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Involves admin of the repository or associated website optimisation Involves optimising performance of code parallel Relates to parallel capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entire coordinate field is sent to one MPI rank for NetCDF outputting.
4 participants