Allow use of SUPG for mixed function spaces #579
Draft
+73
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
reviewed
Nov 26, 2024
| self.wrapper.setup(field_name) | ||
| new_test = self.wrapper.test | ||
| self.residual = self.residual.label_map( | ||
| lambda t: t.get(prognostic) == field_name and t.has_label(transport), |
There was a problem hiding this comment.
can we change this so that we are testing whether the label is not time_derivative? I think it's better if the time discretisation to not know what terms it contains
There was a problem hiding this comment.
If we apply it to the momentum eq, then it will try to replace the test function for all terms with u in, which will be problematic..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SUPG does not work for mixed function spaces. Here I have allowed for the altering of multiple test functions.
Note that MixedFSWrapper is not used, as altering a single test function in the tuple of test functions for a MixedFunctionSpace was difficult to do.
There is scope in future to not use SUPG as a wrapper, but this is not addressed in this pull request.
