Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remove_initial_w
routine no longer works, but I actually don't think it's necessary so this PR removes it.I think we can achieve the same result by including boundary conditions in the initial projection of the velocity field.
This causes a failing test in the case studies but has not been picked up by our normal testing because the
mountain_hydrostatic
test is currently set to xfail, as the hydrostatic equations have not been fixed yet.As a record, below is the error message from
remove_initial_w
: