use correct beta_u in shallow water linear solvers #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
reviewed
Aug 20, 2024
There was a problem hiding this comment.
This puts things in line with the rest of the code ... but the awkward thought I've had is that maybe we don't want the beta values to be constant at all?
In theory we could update dt, but if we did then we would want the beta values to be updated too. At the moment they won't be, so do we actually want:
beta = self.dt*Constant(tau)
instead of
beta_ = self.dt*tau
beta = Constant(beta_)
tommbendall
reviewed
Dec 16, 2024
gusto/solvers/linear_solvers.py
Outdated
| beta_u = dt*self.tau_values.get("u", self.alpha) | ||
| beta_t = dt*self.tau_values.get("theta", self.alpha) | ||
| beta_r = dt*self.tau_values.get("rho", self.alpha) | ||
| beta_u_cp = Constant(beta_u * cp) |
There was a problem hiding this comment.
Can we remove this variable and just have beta_u*cp in the code below?
There was a problem hiding this comment.
Should've known I couldn't get away with being lazy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @Witt-D I didn't notice this in your PR.