fem: cache on instances #4664
Merged
fem: cache on instances #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-collins
reviewed
Oct 20, 2025
leo-collins
reviewed
Oct 20, 2025
leo-collins
reviewed
Oct 20, 2025
ksagiyam
force-pushed
the
ksagiyam/cache_on_instance
branch
from
01b0086 to
bb484ef
Compare
pbrubeck
reviewed
Oct 21, 2025
pbrubeck
reviewed
Oct 21, 2025
pbrubeck
reviewed
Oct 21, 2025
Co-authored-by: Leo Collins <[email protected]> Co-authored-by: Pablo Brubeck <[email protected]>
ksagiyam
force-pushed
the
ksagiyam/cache_on_instance
branch
from
9798e57 to
af33038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the result of
PointSetContext.basis_evaluation()on instance.Currently, result of
ctx.basis_evaluation(), wherectx = PointSetContext(), is cached on class, but the instance is not included in the cache key. This means that implementation changes aroundbasis_evaluation()could cause hard-to-find caching bug. This PR makes the result cached on instance not on class.We should note that the way we handle
mtin the cache key generation is also fragile for the same reason.