Interpolate: map dual argument to reference values for codegen #4652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
commented
Oct 16, 2025
leo-collins
reviewed
Oct 16, 2025
|
|
||
| # Reconstructed Interpolate with mapped operand | ||
| # Reconstructed Interpolate in the reference space | ||
| expression = ufl.Interpolate(operand, v) |
There was a problem hiding this comment.
Can this now become a Firedrake Interpolate?
There was a problem hiding this comment.
In theory yes, but there's no need at this depth of the codegen
leo-collins
force-pushed
the
leo/refactor_interpolate
branch
2 times, most recently
from
cc0276b to
15bdd53
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/interp-reference-value
branch
from
0c2a7a1 to
d54994e
Compare
|
@leo-collins should I merge this to your branch? |
|
#4595 is now passing the tests. Can you rebase this to check if it is passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that the preprocessed
Interpolateused for codegeneration has both arguments in the reference space.Currently there is no analog of
ReferenceValueforBaseForm, so we construct dummy symbols on the reference space.