Skip to content

Conversation

@connorjward
Copy link
Contributor

Description

@connorjward connorjward marked this pull request as ready for review October 13, 2025 12:27
@francesco-ballarin
Copy link
Member

Looks good.

Technically the change should only happen when pushing a tag, rather than on every push to release, because I only update the release install once a tag is prepared and announced. Still, there is very little point in complicating the workflow to handle that, because

  1. even if the notebook repository was updated only on tag push we would still be in a chicken and egg scenario, because you first need to push the tag and once that is done I build the packages.
  2. the changes in the release branch are supposed to be backward compatible (except for those on the day of a brand new release).

@connorjward
Copy link
Contributor Author

Technically the change should only happen when pushing a tag, rather than on every push to release

Good to know. It is very easy to just move this workflow into here instead. I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants