Adapt to UFL changing some methods to properties #4629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
commented
Oct 23, 2025
ksagiyam
previously approved these changes
Oct 23, 2025
|
I think we should just ask downstrems to fix this on their side. |
I agree. This is a critical fix for our own CI. I also warned users about this some time ago. |
connorjward
commented
Oct 23, 2025
|
This can be merged after NGSolve/ngsPETSc#94. For that to be merged we need the CI of both this PR and #4677 to pass to make sure that we're not breaking main or release. |
|
Shall I fix the new conflicts? |
I got it. |
|
@ksagiyam ahall we merge this as is? I can make sure to fix the ngsPETSc branch in a later PR. This is a critical fix as main is currently entirely broken. |
|
Yes, I think we should. |
ksagiyam
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See FEniCS/ufl#385.
Needs firedrakeproject/fiat#192
IMPORTANT
This can be merged after NGSolve/ngsPETSc#94. For that to be merged we need the CI of both this PR and #4677 to pass to make sure that we're not breaking main or release.