Skip to content

Conversation

JHopeCollins
Copy link
Member

This means the call site for Function/Cofunction looks the same as the call site for non-Firedrake types.
Currently to send a non-Firedrake type:

x = ensemble.ensemble_rank
x = ensemble.ensemble_comm.bcast(x, root=0)

This PR changes it to:

x = ensemble.ensemble_rank
x = ensemble.bcast(x, root=0)

@JHopeCollins
Copy link
Member Author

The CI failure is an unrelated linkcheck

Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tiny suggestions. Otherwise happy.

@JHopeCollins JHopeCollins enabled auto-merge (squash) October 21, 2025 12:56
@JHopeCollins JHopeCollins disabled auto-merge October 21, 2025 13:26
@JHopeCollins JHopeCollins enabled auto-merge (squash) October 21, 2025 13:26
@JHopeCollins JHopeCollins disabled auto-merge October 21, 2025 13:26
@JHopeCollins JHopeCollins merged commit 6f1737c into main Oct 21, 2025
6 of 7 checks passed
@JHopeCollins JHopeCollins deleted the JHopeCollins/ensemble_wrappers branch October 21, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants