-
Notifications
You must be signed in to change notification settings - Fork 166
Jax ml operator fix #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jax ml operator fix #4041
Conversation
|
|
@pbrubeck @dham Firedrake pip installs PR depends on the approval of UFL PR 348 and this PR. |
The failure in the docs building is because of a recent Sphinx update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pbrubeck if you are also happy it would be fantastic if this could be merged ASAP as it is holding up the pip PR. Naturally we need to update our UFL fork at the same time.
Description
Depends on firedrakeproject/ufl#60
Fixed an issue in
firedrake.ml.jax.ml_operator
whereargument_slots
was incorrectly specified. I wrote it as optional:Clarified that if
argument_slots
is not provided,ML_Operator
will automatically write it.Test the results involving the Neural operators are in right function space.
Test jax and pytorch operators in Firedrake CI.