Fix ONPolynomialSet normalization #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/normalization
branch
from
46acb06 to
12c5579
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/normalization
branch
from
8974a1f to
5cec49b
Compare
pbrubeck
commented
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpansionSet had an inconsistency and tabulated {1} for degree=0 and {P_j} for degree > 0, where P_0^2 = 1 / default_simplex(dim).volume().
This PR aims to correct the inconsistent definition of the constant member of the expansion set. In addition the expansion is now normalized on the domain it is defined (before the expansion functions had unit L2-norm only on the default simplex).
This changes the scale of some finite element basis functions, and thus breaks regression tests.