chore(cli): point developer search at /v2/search/developer for GA - #180
Merged
Conversation
…fault The developer command called /v2/developer/search. That mount rejects a keyless caller, so keyless developer search never reached the index. It is also the path that may be withdrawn. Call /v2/search/developer, the public path, which accepts a keyless caller. The API returns 10 results by default, not 20. Correct the help text and the README.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The developer command calls
/v2/developer/search. Two problems with that path.It is the path that may be withdrawn.
/v2/search/developeris the public one, and a published CLI cannot be re-pointed after the fact.It also rejects a keyless caller. The API mounts the two paths with different auth:
/v2/search/developerpassesallowKeyless: true,/v2/developer/searchdoes not. The CLI has a keyless mode, sofirecrawl developer "..."without a key has never reached the index — it 401s in the middleware. The route change fixes that too.Also corrects a stale fact: the API returns 10 results by default, not 20. The CLI sends no
kof its own, so the server default is what a user gets.No beta gate here
There is no client-side beta gate to remove. The developer command registers unconditionally and carries no beta labelling. The only gate is server-side: an entitlement check on
developerBetain the API controller. This PR is independent of that flag removal and can merge in either order.Testing
pnpm run format:check,pnpm run type-check,pnpm run build,pnpm test— all pass (404 tests).firecrawl developer --helprenders the corrected default.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Switched the developer command to
/v2/search/developer(public GA path) so keyless mode works and the path stays stable. Corrected the default results to 10 in--helpand the README.Written for commit cb862f2. Summary will update on new commits.