Skip to content

DO NOT MERGE test #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bchalios
Copy link
Contributor

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

bchalios added 4 commits June 17, 2025 11:07
Fix a typo in a test comment

Signed-off-by: Babis Chalios <[email protected]>
Firecracker IO is software emulated by the VMM thread of the Firecracker
process. This is a single thread so it could be the case that a single
device can starve other devices. This could happen if a guest keeps
adding descriptors in a queue while we are processing it. Our emulation
logic should include railguards against such behaviour. Add a test that
verifies that this is the case.

Signed-off-by: Babis Chalios <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.88%. Comparing base (266599a) to head (476dd37).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/vmm/src/devices/virtio/block/virtio/device.rs 40.00% 3 Missing ⚠️
...m/src/devices/virtio/block/virtio/event_handler.rs 50.00% 3 Missing ⚠️
src/vmm/src/devices/virtio/net/event_handler.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5265      +/-   ##
==========================================
+ Coverage   82.84%   82.88%   +0.03%     
==========================================
  Files         250      250              
  Lines       26967    26981      +14     
==========================================
+ Hits        22342    22362      +20     
+ Misses       4625     4619       -6     
Flag Coverage Δ
5.10-c5n.metal 83.31% <46.66%> (-0.03%) ⬇️
5.10-m5n.metal 83.30% <46.66%> (-0.03%) ⬇️
5.10-m6a.metal 82.53% <46.66%> (-0.03%) ⬇️
5.10-m6g.metal 79.14% <46.66%> (-0.03%) ⬇️
5.10-m6i.metal 83.30% <46.66%> (-0.03%) ⬇️
5.10-m7a.metal-48xl 82.51% <46.66%> (?)
5.10-m7g.metal 79.14% <46.66%> (-0.03%) ⬇️
5.10-m7i.metal-24xl 83.27% <46.66%> (?)
5.10-m7i.metal-48xl 83.27% <46.66%> (?)
5.10-m8g.metal-24xl 79.14% <46.66%> (?)
5.10-m8g.metal-48xl 79.14% <46.66%> (?)
6.1-c5n.metal 83.36% <46.66%> (-0.03%) ⬇️
6.1-m5n.metal 83.36% <46.66%> (-0.02%) ⬇️
6.1-m6a.metal 82.57% <46.66%> (-0.03%) ⬇️
6.1-m6g.metal 79.14% <46.66%> (-0.03%) ⬇️
6.1-m6i.metal 83.35% <46.66%> (-0.02%) ⬇️
6.1-m7a.metal-48xl 82.55% <46.66%> (?)
6.1-m7g.metal 79.14% <46.66%> (-0.03%) ⬇️
6.1-m7i.metal-24xl 83.36% <46.66%> (?)
6.1-m7i.metal-48xl 83.36% <46.66%> (?)
6.1-m8g.metal-24xl 79.13% <46.66%> (?)
6.1-m8g.metal-48xl 79.14% <46.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant