fix: validate iat and nbf on payload #568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
christiandavilakoobin
force-pushed
the
main
branch
from
1890da5 to
f4b20e0
Compare
robocoder
reviewed
Jan 3, 2025
| @@ -172,7 +182,7 @@ public static function decode( | |||
| } | |||
|
|
|||
| // Check if this token has expired. | |||
| if (isset($payload->exp) && ($timestamp - static::$leeway) >= $payload->exp) { | |||
| if (isset($payload->exp) && floor($payload->exp) && ($timestamp - static::$leeway) >= $payload->exp) { | |||
There was a problem hiding this comment.
the floor() change here is unnecessary if the exception has already been thrown above
|
overlaps with #453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a JWT has a nonumeric iat or nbf value, it throws a FATAL error when validating the field.