-
Notifications
You must be signed in to change notification settings - Fork 611
feat(js/plugins/compat-oai): allow passing api key at runtime instead of config time #3946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ssbushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of supporting per-request API keys?
Folks build apps where user provides the API key. The key is dynamically fetched from a DB. |
ssbushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, save for 1 small comment.
Checklist (if applicable):