refactor(js): refactored dynamic action variants of models, embedders, background models, etc. into separate fns #3417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, background models, etc. into separate fns
pavelgj
commented
Aug 14, 2025
| */ | ||
| export function embedder<ConfigSchema extends z.ZodTypeAny = z.ZodTypeAny>( | ||
| options: EmbedderOptions<ConfigSchema>, | ||
| runner: ( |
There was a problem hiding this comment.
one thing of note: the embedder factory runner function signature is different from defineEmbedder. The new one is more aligned with the action interface, allowing access to context, etc.
pavelgj
commented
Aug 14, 2025
| * Defines a dynamic resource. Dynamic resources are just like regular resources but will not be | ||
| * registered in the Genkit registry and can be defined dynamically at runtime. | ||
| */ | ||
| export function resource( |
There was a problem hiding this comment.
standardizing on naming, s/dynamicResource/resource/
pavelgj
commented
Aug 14, 2025
| * Defines a dynamic tool. Dynamic tools are just like regular tools but will not be registered in the | ||
| * Genkit registry and can be defined dynamically at runtime. | ||
| */ | ||
| export function tool<I extends z.ZodTypeAny, O extends z.ZodTypeAny>( |
There was a problem hiding this comment.
standardizing on naming, s/dynamicTool/tool/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):