-
Notifications
You must be signed in to change notification settings - Fork 325
feat: release candidate CI to allow for kokoro signing #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3303425
to
e07967a
Compare
d55d25c
to
cca6438
Compare
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
name: Sign Binaries (Manual) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavelgj this is just an example, we could trigger kokoro automatically or some other flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive release candidate workflow that enables proper binary signing integration with Kokoro for the Genkit CLI. The workflow creates a safe two-stage release process where unsigned binaries are first published as a release candidate, then signed externally, and finally promoted to a stable release.
Key Changes
- Added RC creation workflow that builds and publishes unsigned binaries for testing
- Implemented external signing simulation process with validation
- Created promotion workflow that validates signed binaries and creates final releases
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
.github/workflows/build-cli-binaries.yml |
Enhanced to support RC creation with unsigned binaries and comprehensive testing |
.github/workflows/sign-binaries-manual.yml |
New workflow for manual binary signing simulation with validation |
.github/workflows/promote-cli-release.yml |
New workflow to promote signed RCs to final releases with safety checks |
scripts/sign-and-upload-binaries.sh |
Shell script that simulates the external signing process and uploads signed binaries |
ab9c2b9
to
58c4d3f
Compare
58c4d3f
to
1235e3a
Compare
Implements a proper release candidate → final release workflow with signing integration points.
Key Changes
New RC Flow:
create_rc=true
→ Creates RC with unsigned binaries (marked as prerelease)promote_rc=true
→ Validates signed binaries exist, then promotes to final releaseWorkflow Safety:
latest
tag on final releases, not RCsProcess: