Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump Firebase iOS SDK FirebaseCore pod to v11.4.1 #13539

Closed
wants to merge 6 commits into from
Closed

fix: bump Firebase iOS SDK FirebaseCore pod to v11.4.1 #13539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9592f70
feat: bump Firebase iOS SDK to `v11.4.1`
russellwheatley Oct 23, 2024
1352be7
try with 11.4.0 as frameworks isn't picking up hot fix
russellwheatley Oct 23, 2024
0c5f3fd
update core podspecs so it only changes to 11.4.1
russellwheatley Oct 23, 2024
dc3820e
Discard changes to packages/cloud_firestore/cloud_firestore/example/i…
russellwheatley Oct 23, 2024
54943ac
Discard changes to packages/cloud_firestore/cloud_firestore/example/m…
russellwheatley Oct 23, 2024
9d4d20a
update podspec dependency
russellwheatley Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/firebase_core/firebase_core/ios/firebase_core.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ else
firebase_sdk_version = firebase_sdk_version!
Pod::UI.puts "#{pubspec['name']}: Using Firebase SDK version '#{firebase_sdk_version}' defined in 'firebase_core'"
end

if firebase_sdk_version == '11.4.0'
# temporary measure for hot fix, https://github.com/CocoaPods/Specs/blob/master/Specs/0/3/5/Firebase/11.4.1/Firebase.podspec.json
# only FirebasCore has changed to 11.4.1
firebase_sdk_version = '11.4.1'
end

end

Pod::Spec.new do |s|
Expand All @@ -33,7 +40,9 @@ Pod::Spec.new do |s|
s.dependency 'Flutter'

# Firebase dependencies
s.dependency 'Firebase/CoreOnly', firebase_sdk_version
s.dependency 'FirebaseCore', firebase_sdk_version
# TODO - needs reinstating once we move to 11.5.0, and the above removing
# s.dependency 'Firebase/CoreOnly', firebase_sdk_version

s.static_framework = true
s.pod_target_xcconfig = {
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_core/firebase_core/ios/firebase_sdk_version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# https://firebase.google.com/support/release-notes/ios
def firebase_sdk_version!()
'11.2.0'
'11.4.0'
end
10 changes: 9 additions & 1 deletion packages/firebase_core/firebase_core/macos/firebase_core.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ else
firebase_sdk_version = firebase_sdk_version!
Pod::UI.puts "#{pubspec['name']}: Using Firebase SDK version '#{firebase_sdk_version}' defined in 'firebase_core'"
end

if firebase_sdk_version == '11.4.0'
# temporary measure for hot fix, https://github.com/CocoaPods/Specs/blob/master/Specs/0/3/5/Firebase/11.4.1/Firebase.podspec.json
# only FirebasCore has changed to 11.4.1
firebase_sdk_version = '11.4.1'
end
end

begin
Expand Down Expand Up @@ -51,7 +57,9 @@ Pod::Spec.new do |s|
s.dependency 'FlutterMacOS'

# Firebase dependencies
s.dependency 'Firebase/CoreOnly', "~> #{firebase_sdk_version}"
s.dependency 'FirebaseCore', "~> #{firebase_sdk_version}"
# TODO - needs reinstating once we move to 11.5.0, and the above removing
# s.dependency 'Firebase/CoreOnly', "~> #{firebase_sdk_version}"

s.static_framework = true
s.pod_target_xcconfig = {
Expand Down
Loading