[Messaging] Include theme in AndroidManifest

[a-maurice]

Description

Provide details of the change, and generalize the change in the PR title above.

Include a theme in the generated AndroidManifest file with messaging, handling activity vs game activity settings. This fixes a crash on Unity 6, where it seems to require a theme to be set.

Fixes #1229

---

Testing

Describe how you've tested these changes.

Running locally on both Unity 2021 and Unity 6

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

[gemini-code-assist]

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request fixes a specific crash encountered by users of Firebase Messaging on Unity 6 by ensuring that the Messaging activity in the generated AndroidManifest has a theme defined. It includes a build preprocessor to automatically manage this theme attribute, adapting to whether the project uses the standard Unity Activity or the newer GameActivity.

Highlights

• Bug Fix: Addresses a crash occurring on Unity 6 when using Firebase Messaging due to a missing theme in the AndroidManifest.
• AndroidManifest Modification: Adds the android:theme attribute to the MessagingUnityPlayerActivity definition in the generated AndroidManifest.xml.
• Build Preprocessor: Introduces a new build preprocessor (FirebaseMessagingAndroidManifestModifier) to automatically ensure the correct theme (@style/UnityThemeSelector or @style/BaseUnityGameActivityTheme for Unity 2023+ GameActivity) is set on the Messaging activity in the AndroidManifest during the build process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a mechanism to ensure the correct Android theme is applied to the MessagingUnityPlayerActivity in AndroidManifest.xml, fixing a crash on Unity 6. A new pre-build processor dynamically checks and sets the theme, considering GameActivity usage in newer Unity versions. The SDK's default AndroidManifest.xml is also updated with a theme. The review suggests enhancing the manifest modification logic by checking for a valid Android namespace declaration.