-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(emulator): skip legacy monkeypatching for firebase-functions v7+ #9401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Detects `firebase-functions` v7+ in the emulator runtime and skips legacy stubs and config helpers that are incompatible with the new SDK version, preserving backward compatibility for older versions.
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase emulator's compatibility by introducing version-aware logic for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds a version check to skip legacy monkeypatching for firebase-functions v7 and newer. My review focuses on improving the implementation by addressing code duplication. The version check and firebase-functions module resolution are performed in multiple places. I've suggested a refactoring to centralize this logic in the initializeRuntime function. This will make the code more efficient by avoiding redundant module lookups and more maintainable by removing duplicated code.
Detects
firebase-functionsv7+ in the emulator runtime and skips legacy stubs and config helpers that are incompatible with the new SDK version, preserving backward compatibility for older versions.