-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CLI for Remote Config Experiments #9052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
109ec6c
to
f6f6710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Let's also update https://github.com/firebase/firebase-tools/blob/master/README.md#remote-config-commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry - otherwise, this LGTM
Description
This PR adds the implementation of the CLI utility for Remote Config Experiments. The operations exposed are:
GetExperiment
ListExperiments
DeleteExperiment
Scenarios Tested
FirebaseError
and returns it--json
flag forGet
,List
andDelete
experimentsGetExperiment
andDeleteExperiment
share similar test cases:Expectation: The user should pass the
experimentID
that is required to be fetched / deleted.Test cases:
experimentId
experimentId
ListExperiment
Expectation: The user can optionally pass a
filter
,page_size
andpage_token
.page_size
number of experiments10
experiments after thepage_token
or remaining experiments (minimum of both)page_token
andpage_size
page_size
number of experiments starting atpage_token
page_token
,page_size
andfilter
page_token
Sample Commands
GetExperiment
firebase remoteconfig:experiments:get <experiment ID>
ListExperiment
firebase remoteconfig:experiement:list --filter <optional filter> --page_size <optional page size> --page token <optional page token>
DeleteExperiment
firebase remoteconfig:experiments:delete <experiment ID>