Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting of connector evolution and insecure operation issues. #8204

Merged
merged 7 commits into from
Feb 14, 2025

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Feb 11, 2025

Description

Address formatting issues from bug bash:

  • Add a extra column for issue type
  • Present FYI/warning issues as a table as well
  • Move BREAKING issues above INSECURE issues, and group issues by type
  • Update wording of warnings and prompts to also reflect the insecure operations linter

Scenarios Tested

Sample Commands

Screenshot 2025-02-12 at 2 20 05 PM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.17%. Comparing base (c0226eb) to head (fcdba12).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
src/dataconnect/graphqlError.ts 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8204      +/-   ##
==========================================
+ Coverage   51.12%   51.17%   +0.05%     
==========================================
  Files         423      423              
  Lines       29722    29750      +28     
  Branches     6083     6090       +7     
==========================================
+ Hits        15196    15226      +30     
+ Misses      13160    13155       -5     
- Partials     1366     1369       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosalyntan rosalyntan marked this pull request as ready for review February 12, 2025 22:27
@rosalyntan rosalyntan requested a review from joehan February 12, 2025 22:28
@rosalyntan rosalyntan enabled auto-merge (squash) February 14, 2025 20:23
@rosalyntan rosalyntan merged commit ed3bde4 into master Feb 14, 2025
51 of 56 checks passed
@rosalyntan rosalyntan deleted the rosalyntan.op branch February 14, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants