Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #8168 - enforce webframeworks only when needed #8169

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+154 −10
Open

fix: #8168 - enforce webframeworks only when needed #8169

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a9c586b
fix: #8168 - enforce webframeworks only when needed
fivecar Feb 5, 2025
7b68a0e
remove console
fivecar Feb 5, 2025
6e8b10b
add changelog, add tests
fivecar Feb 5, 2025
f3d6a1f
Merge branch 'master' into 8168-fix
fivecar Feb 5, 2025
6507875
Merge branch 'master' into 8168-fix
fivecar Feb 6, 2025
00cc1fc
Add matchesHostingTarget to improve readability
chalosalvador Feb 14, 2025
538b024
Merge branch 'master' of github.com:firebase/firebase-tools into 8168…
chalosalvador Feb 14, 2025
2fa91a6
Merge branch 'master' into 8168-fix
fivecar Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/deploy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,17 @@ export const deploy = async function (

if (targetNames.includes("hosting")) {
const config = options.config.get("hosting");
if (Array.isArray(config) ? config.some((it) => it.source) : config.source) {
if (
Array.isArray(config)
? config.some(
(it) =>
it.source &&
(!options.only.includes("hosting:") ||
new RegExp(`\\bhosting:${it.target}\\b`).exec(options.only)),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is lame, and reflects my lack of understanding of all the config flags/etc and how best to parse this. But the point is to make this logic, "Enforce webframeworks if either all sites need to be deployed, or if the site being deployed itself has source").

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivecar I just pushed this commit to improve readability and to handle the case when using firebase deploy which was erroring out.
All the functionality should remain the same.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - it looks so much better, @chalosalvador . Thanks for your help and support!

)
: config.source
) {
console.log("preparing webframeworks");
experiments.assertEnabled("webframeworks", "deploy a web framework from source");
await prepareFrameworks("deploy", targetNames, context, options);
}
Expand Down