Remove AbortController polyfill as it is no longer needed and use native fetch where possible #8162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive fetch where possible
talentlessguy
commented
Feb 1, 2025
| @@ -374,7 +371,7 @@ export class Client { | |||
| reqTimeout = setTimeout(() => { | |||
| controller.abort(); | |||
| }, options.timeout); | |||
| fetchOptions.signal = controller.signal; | |||
| fetchOptions.signal = controller.signal as RequestInit["signal"]; | |||
There was a problem hiding this comment.
this is due to node-fetch AbortController types not being up-to-date with the runtime AbortController which supports more features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a redundant
AbortControllerpolyfill, since it's supported natively in Node.js since v14.18, and Firebase minimum target is 18. It also removes fetch polyfill where it's not needed anymore, however I had to leave it be in one place because of usage of custom HTTP agents, which native fetch doesn't support yet. node-fetch-native supports proxies but not custom http agents based on what I know.Scenarios Tested
I've run
npm test, and a bunch of unrelated tests started failing (assertions). Will see what I can do. Linting passes though