Fix for functions.ignore excluding deeper directories #8132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have fix for this ready, don't know if you want to allow the tests to be run to fail first and then I can push the fix? LMK |
joehan
reviewed
Jan 28, 2025
| @@ -16,22 +16,24 @@ export interface ReaddirRecursiveFile { | |||
| } | |||
|
|
|||
| async function readdirRecursiveHelper(options: { | |||
There was a problem hiding this comment.
This seems broken to me at the moment - you've changed the signsture of readdirRecursiveHelper but not changed any of its call sites.
There was a problem hiding this comment.
The only call sites for this function are itself and the other function and both are updated! You mind being more explicit and pointing out the missing ones please?
rhodgkins
changed the title
|
@blidd-google done - LMK if you need anything else. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8131
This updates
readdirRecursiveHelperby adding in abasePathparameter which is used for the directory that should be read, while the existingpathparameter is now used as the path for filtering (and recursing into directories). This means that all ignores are based on the relative directory tobasePathand not the full filesystem path as they were before.