Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run vscode tests in the CI #7001
Run vscode tests in the CI #7001
Changes from 17 commits
fa1fa1e
4dc3d2c
2118c2a
91d414e
dcd56f8
6b0b07e
54ceaf8
59a7ab9
145982e
7e91fe9
95f0465
efbb4d0
f73fa8f
215a5ef
926dac0
d76a54c
a91768d
de38707
14614de
a5b51f7
72c09e8
4ad8c93
f9744d4
aee996e
1e9171c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be firebase-vscode/[package-lock.json instead (or in addition)? I assume we want to cache the vscode deps here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking - if you remove this line, do the tests still pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt it. We have to run
npm i
in both the root and the vscode folder.The
npm i -g
above doesn't count as it only updates the npm version and nothing else.