Pin [email protected]. Fix #1606. #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
reviewed
Aug 19, 2019
package.json
Outdated
| @@ -92,7 +92,7 @@ | |||
| "minimatch": "^3.0.4", | |||
| "open": "^6.3.0", | |||
| "ora": "^3.4.0", | |||
| "portfinder": "^1.0.13", | |||
| "portfinder": "1.0.21", | |||
There was a problem hiding this comment.
Because 1.0.22 introduced a breaking change http-party/node-portfinder#84
There was a problem hiding this comment.
Sorry, wrong link. http-party/node-portfinder#89 describes better what we're experiencing.
There was a problem hiding this comment.
portfinder has released a fix. I've updated the code to read ^1.0.23. This PR is no longer urgent. https://www.npmjs.com/package/portfinder/v/1.0.23
|
Once all comments are resolved please feel free to merge and release without me :) |
bkendall
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1606.