Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup JS files with rollup-typescript-plugin #8503

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Commits on Sep 16, 2024

  1. Rollup JS files with rollup-typescript-plugin

    The rollup-typescript-plugin does not transpile JS files using the TS
    compiler by default. This means that external dependencies that provide
    JS bundles will not be transpiled to the target ES version specified in
    the TypeScript config used by the plugin.
    
    This resulted in one of our dependencies (https://github.com/jakearchibald/idb)
    being included in the CDN bundles without being transpiled to
    ES5 (the target ES version). Since this dependencies bundle uses
    ES2018 syntax (object spread operator `{ ...x }`), this upgraded our CDN
    bundles' minimum ES version requirement to ES2018 which isn't compatible with older browser versions.
    To see the ES2018 syntax in one of the CDN bundles, see
    https://www.gstatic.com/firebasejs/10.13.1/firebase-app.js and search for `...oldTraps`.
    dlarocque committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dc115a2 View commit details
    Browse the repository at this point in the history